[sddm-theme] Improve positioning of Clock
AbandonedPublic

Authored by davidedmundson on Mar 15 2017, 7:42 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Summary

This is the same as 097db85e297aba8b4b3f0ddabcddf8a03b5482c0 for the
lockscreen.

The clock so far was manually positioned in a hard coded way which could
result in the clock not being visible.

This changes the layouting of the clock to use a ColumnLayout, with
spacer elements to ensure that the clock stays visible. It is possible
that the position of the clock now does no longer fully reflects the
ideas of the VDG.

Diff Detail

Repository
R120 Plasma Workspace
Branch
sddm-theme-clock
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Mar 15 2017, 7:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 15 2017, 7:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Mar 16 2017, 5:16 PM

I'm not sure i really like this approach, a columnlayout with an empty item just for spacing really looks like an hack.

since it can't be reparented with the rest as it should stay fixed, i think the stack view (or more precisely, either MainBlock or SessionManagementScreen) should expose as a property the space they have on top of the user list, so the clock would either position itself in the middle of it, or hide itself if there is not enough space

mart added a comment.Mar 17 2017, 11:44 AM

if you are ok, i would give its layouting the same treatment of D4893

In D5063#95576, @mart wrote:

if you are ok, i would give its layouting the same treatment of D4893

sure!

mart added a comment.Mar 17 2017, 4:41 PM

ok, so, push D5061, then i can play on top of it :)

mart added a comment.Apr 21 2017, 2:41 PM

this has been implemented differently, can be dropped

sebas added a subscriber: sebas.May 5 2017, 8:20 AM

@graesslin Can you abandon this review? :)

davidedmundson commandeered this revision.Aug 18 2017, 12:21 AM
davidedmundson abandoned this revision.
davidedmundson added a reviewer: graesslin.