Honor KFileItem isHidden() in view
ClosedPublic

Authored by broulik on Mar 8 2017, 12:55 PM.

Details

Summary

Instead of just assuming hidden files always start with a "."
The items were already filtered out but when showing hidden files they weren't painted at reduced opacity.

Test Plan

If I set UDS_HIDDEN in a KIO slave the file will now show with reduced opacity if I enable show hidden files

(note the "Basisordner")

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 8 2017, 12:55 PM
emmanuelp requested changes to this revision.Mar 8 2017, 1:27 PM
emmanuelp added inline comments.
src/kitemviews/kfileitemlistwidget.cpp
123

KFileItem::isHidden() already checks if the file name starts with a dot, so this check can be removed.

This revision now requires changes to proceed.Mar 8 2017, 1:27 PM
broulik updated this revision to Diff 12293.Mar 8 2017, 1:33 PM
broulik edited edge metadata.
  • Remove custom startsWith(".") check
emmanuelp accepted this revision.Mar 8 2017, 1:38 PM

Nice!

This revision is now accepted and ready to land.Mar 8 2017, 1:38 PM
This revision was automatically updated to reflect the committed changes.