Differential D4925

actually delete old theme caches
ClosedPublic
Actions

Authored by mart on Mar 3 2017, 4:20 PM.

Details

Reviewers
sitter
Group Reviewers
Plasma
Commits
R242:bbcb217b4812: actually delete old theme caches
Summary

QStandardPaths doesn't do file search by wildcards,
that code was never actually functional

Test Plan

old kcache and rects cache files get correctly removed

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mar 3 2017, 4:20 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMar 3 2017, 4:20 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
apol added a subscriber: apol.Mar 3 2017, 4:40 PM
apol added inline comments.
src/plasma/private/theme_p.cpp
221

Use entryInfoList? This way you won't have to construct the path again...

270

Same

mart updated this revision to Diff 12262.Mar 7 2017, 12:58 PM

use QFileInfo

sitter accepted this revision.Mar 7 2017, 1:03 PM
sitter added a subscriber: sitter.

lgtm

This revision is now accepted and ready to land.Mar 7 2017, 1:03 PM
davidedmundson added a subscriber: davidedmundson.Mar 7 2017, 1:12 PM
davidedmundson added inline comments.
src/plasma/private/theme_p.cpp
271

do we not want

if (! file.fileName() ==

?

Closed by commit R242:bbcb217b4812: actually delete old theme caches (authored by mart). · Explain WhyMar 7 2017, 1:16 PM
This revision was automatically updated to reflect the committed changes.
mart marked 2 inline comments as done.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/private/theme_p.cpp (20 lines)

Diff 12264

View Options

src/plasma/private/theme_p.cpp

Loading...