Split frag and vert code of FadingNode into separate files
ClosedPublic

Authored by davidedmundson on Feb 28 2017, 11:48 PM.

Details

Summary

This matches what Qt does internally, it's easier to read and gives us
syntax highlighting on the shader files, but more importantly in future
we will get Qt's automatic loading of core profile shaders.

Test Plan

Opened QML with IconItem, made the icon switch.
Still looks the same

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 28 2017, 11:48 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Mar 1 2017, 9:26 AM

+1

src/declarativeimports/core/fadingnode.cpp
57 ↗(On Diff #11980)

Maybe?

return {QByteArrayLiteral("..."), QByteArrayLiteral("...")};
src/declarativeimports/core/shaders.qrc
2 ↗(On Diff #11980)

plasma-framework?

mart added a subscriber: mart.Mar 1 2017, 12:11 PM

agree on plasma-framework, in general, looks way cleaner :)

src/declarativeimports/core/shaders.qrc
2 ↗(On Diff #11980)

+1

Change prefix

mart accepted this revision.Mar 2 2017, 9:20 AM
This revision is now accepted and ready to land.Mar 2 2017, 9:20 AM
This revision was automatically updated to reflect the committed changes.