Implement FadingMaterial frag/vert shaders on core profile
ClosedPublic

Authored by davidedmundson on Mar 1 2017, 3:11 AM.

Details

Summary

Like all the inbuilt shaders this now has a separate GLS source file which
works with a newer version without requiring compatibility.

Was https://git.reviewboard.kde.org/r/128426/

Test Plan

Ran plasmashell with ForceGlCoreProfile set in the config
Hovered an icon in the task manager and it animated to the correct one
correctly.
Ran glslangValidator on both files. No warnings.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Mar 1 2017, 3:11 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptMar 1 2017, 3:11 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Mar 1 2017, 7:48 PM

tried it now on ati proprietary, the icon does have the highlight effect at the end of the animation but disappear during the animation.

on terminal i have the following error:
shader compilation failed:
"Vertex shader(s) failed to link, fragment shader(s) failed to link.\nVertex link error: INVALID_OPERATION.\nERROR: error(#97) No program main found\nfragment link error: INVALID_OPERATION.\nERROR: error(#97) No program main found\n"
QOpenGLShader:🔗 Vertex shader(s) failed to link, fragment shader(s) failed to link.
Vertex link error: INVALID_OPERATION.
ERROR: error(#97) No program main found
fragment link error: INVALID_OPERATION.
ERROR: error(#97) No program main found

mart added a comment.EditedMar 1 2017, 7:59 PM

also,
Failed to find shader ":/plasma-framework/shaders/fadingmaterial_core.vert"
Failed to find shader ":/plasma-framework/shaders/fadingmaterial_core.frag"
QOpenGLShader:🔗 Vertex shader(s) failed to link, fragment shader(s) failed to link.
Vertex link error: INVALID_OPERATION.
ERROR: error(#97) No program main found
fragment link error: INVALID_OPERATION.
ERROR: error(#97) No program main found

(the resource files are correctly generated)

mart added a comment.Mar 1 2017, 9:44 PM

sorry for the noise, it was a local setup problem, it works correctly now
+1 from me

mart accepted this revision.Mar 2 2017, 9:20 AM
This revision is now accepted and ready to land.Mar 2 2017, 9:20 AM
This revision was automatically updated to reflect the committed changes.