Details
Details
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Would it be a good idea to push this, d479 and d498 to a branch for easier testing? Or is the refactoring complete in which case it can go into master, of course. I'm fine with the approach, just worried that it would break stuff right now.
Comment Actions
- No risk of pushing this particular diff in my opinion. This one is the smallest change of the three.
- The work I've done is good to go as far as usability. arc patch D498 to test everything including the latest changes. The shortcut editor is quite a lot better in my opinion, and the refactoring everywhere else makes it much easier to manage actions throughout the code base.
- What I'm concerned about is the huge i18n changes. arc patch D479 for that. Maybe it's better to just test D498 and see if the results are satisfactory. I'm just crossing my fingers here, I have no experience with this.
- If you prefer that I push a testing branch to the main repo I can do that too. Arcanist is quite nice though.
Comment Actions
Okay, let's go ahead. When it lands, I'll ask people from the i18n team to check everything is still okay.