Move action factory work and shortcut dialog into KisActionRegistry
ClosedPublic

Authored by abrahams on Oct 30 2015, 6:15 PM.

Details

Summary

This removes most of the shortcut management code from KisPart.

Depends on D476

Tasks: T947

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abrahams updated this revision to Diff 1113.Oct 30 2015, 6:15 PM
abrahams retitled this revision from to Move action factory work and shortcut dialog into KisActionRegistry.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added a reviewer: rempt.
abrahams updated this object.Oct 30 2015, 6:55 PM
rempt edited edge metadata.Nov 12 2015, 7:26 AM

Would it be a good idea to push this, d479 and d498 to a branch for easier testing? Or is the refactoring complete in which case it can go into master, of course. I'm fine with the approach, just worried that it would break stuff right now.

abrahams added a comment.EditedNov 13 2015, 8:44 AM
  • No risk of pushing this particular diff in my opinion. This one is the smallest change of the three.
  • The work I've done is good to go as far as usability. arc patch D498 to test everything including the latest changes. The shortcut editor is quite a lot better in my opinion, and the refactoring everywhere else makes it much easier to manage actions throughout the code base.
  • What I'm concerned about is the huge i18n changes. arc patch D479 for that. Maybe it's better to just test D498 and see if the results are satisfactory. I'm just crossing my fingers here, I have no experience with this.
  • If you prefer that I push a testing branch to the main repo I can do that too. Arcanist is quite nice though.
rempt accepted this revision.Nov 14 2015, 9:13 AM
rempt edited edge metadata.

Okay, let's go ahead. When it lands, I'll ask people from the i18n team to check everything is still okay.

This revision is now accepted and ready to land.Nov 14 2015, 9:13 AM
This revision was automatically updated to reflect the committed changes.