But since you're moving KoResourcePaths around, please check what Friedrich has been doing to KoResourcePaths in calligra's master branch. Should we do something similar?

This revision is now accepted and ready to land.Nov 3 2015, 7:18 AM

Never mind the previous comment - let me look into that.

I think it would be fine to simply copy Friedrich's new KoResourcePaths code. It looks like there are various benefits to tidying up and the main benefit is to make searching more robust, but the usage stays the same.

I'd like to push this without doing that though, since AFAIK we weren't having any bugs with searching right now.

Okay

Closed by commit R37:664bb1fa498e: Add KisActionRegistry (authored by abrahams). · Explain WhyNov 3 2015, 9:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		krita/ui/KisPart.cpp (158 lines)
M		libs/widgets/CMakeLists.txt (1 line)
V		libs/{widgets → widgetutils}/KoResourcePaths.h
V		libs/{widgets → widgetutils}/KoResourcePaths.cpp
M		libs/widgetutils/CMakeLists.txt (2 lines)
V		libs/{widgetutils ← widgets}/KoResourcePaths.h (4 lines)
V		libs/{widgetutils ← widgets}/KoResourcePaths.cpp
A	M	libs/widgetutils/kis_action_registry.h (90 lines)
A	M	libs/widgetutils/kis_action_registry.cpp (172 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1111	c884804		Oct 30 2015, 5:55 PM	★	★
Diff 2	1149	c8b1efd	Commit rKRITA664bb1fa498ecd28e3078a5f83cfc46cf587908c	Nov 3 2015, 9:46 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
857b4b48e102	f8a888295f6e	c884804eceeb	Michael Abrahams	Add KisActionRegistry (Show More…)	Oct 27 2015, 1:53 AM

Status	Author	Revision
Closed	abrahams	D479 Port away from `new QAction` retaining i18n strings
Closed	abrahams	D478 Move action factory work and shortcut dialog into KisActionRegistry
Closed	abrahams	D476 Add KisActionRegistry