[FrameSvgItemMargins] Don't update on repaintNeeded
ClosedPublic

Authored by broulik on Feb 20 2017, 3:47 PM.

Details

Summary

FrameSvgItem already updates the margins in response to that.

Test Plan

FrameSvgItem has

connect(m_frameSvg, SIGNAL(repaintNeeded()), this, SLOT(doUpdate()));

and in doUpdate does

m_margins->update();
m_fixedMargins->update();

I still get tons of binding loop warnings on e.g. "topMargin" in Plasma

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 20 2017, 3:47 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 20 2017, 3:47 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Feb 20 2017, 3:52 PM
This revision is now accepted and ready to land.Feb 20 2017, 3:52 PM
drosca edited edge metadata.Feb 20 2017, 3:52 PM

Looks fine, but unfortunately it doesn't help with anything, the issue with networkmanager applet delegates is still there.

This revision was automatically updated to reflect the committed changes.