| dhaumann | |
| cullmann |
| KTextEditor |
I'm currently writing an application where the user is expected to type some code in, but it isn't then saved to a file, but it is just passed back to the application in memory.
It's misleading to the user for them to press Ctrl+S and then a save dialog comes up--they shouldn't be saving it!
Here's my fix. Any suggestions are welcome.
I added a basic test to the test suite, it's not very good though. I wanted to make sure that the documentSaveAs function was failing _before_ I called setSaveEnabled, but that would require somehow pressing "cancel" on the file dialog which I do not know how to do, if it's possible at all.
| Lint Skipped |
| Unit Tests Skipped |
Updated the test to be slightly better. Use QVERIFY(...) instead of QCOMPARE(..., true) in one case, and make sure that saveEnabled() is false after calling setSaveEnabled(false).
I think we don't need this patch: The solution is to disable the save and saveAs actions: Iterate over the document's KActionCollection to find the correct actions (see katepart5ui.rc), and then disable / remove them. This is also how KDevelop and Kate once did this, iirc.
See:
If this does not work for you, please extend the ConfigInterface that the Document inherits. Does that work for you?
Please discard this patch for now. Feel free to make a new patch with the ConfigInterface in case the proposed solution with the action collection does not work.