Differential D4563

Replace warps-slider checkbox with radio buttons
ClosedPublic
Actions

Authored by elvisangelaccio on Feb 11 2017, 11:03 AM.

Details

Reviewers
mart
colomar
broulik
Commits
R99:57403a78afa2: Replace warps-slider checkbox with radio buttons
Summary

This was suggested by Thomas in
https://git.reviewboard.kde.org/r/128475/ but it probably got lost.

The "Left mouse warps scroll bar" checkbox is very hard to understand, so
we replace it with a buttongroup with two radio buttons that explain
what actually happens in either case.

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 11207.Feb 11 2017, 11:03 AM
elvisangelaccio retitled this revision from to Replace warps-slider checkbox with radio buttons.
elvisangelaccio updated this object.
elvisangelaccio added reviewers: broulik, colomar.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 11 2017, 11:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
colomar edited edge metadata.EditedFeb 11 2017, 2:54 PM

I'm all for the change, obviously ;)

Two small change suggestions:

  1. left clicking -> left-clicking
  2. Up/down one page -> one page up/down
elvisangelaccio updated this revision to Diff 11233.Feb 11 2017, 5:45 PM
elvisangelaccio edited edge metadata.
  • Fix strings as suggested by Thomas
elvisangelaccio added a comment.Feb 11 2017, 5:46 PM

Updated screenshot:

mart accepted this revision.Feb 22 2017, 4:36 PM
This revision is now accepted and ready to land.Feb 22 2017, 4:36 PM
Closed by commit R99:57403a78afa2: Replace warps-slider checkbox with radio buttons (authored by elvisangelaccio). · Explain WhyFeb 23 2017, 3:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/gtkconfigkcmodule.cpp (12 lines)
Msrc/ui/gui.ui (383 lines)

Diff 11699

View Options

src/gtkconfigkcmodule.cpp

Loading...
View Options

src/ui/gui.ui

Loading...