Differential D4553

[KStandardItemListWidget] Support QIcon from path in addition to fromTheme
AbandonedPublic
Actions

Authored by broulik on Feb 10 2017, 7:45 PM.

Details

Reviewers
emmanuelp
dfaure
Summary

This way icons set through a path in e.g. a .desktop file work.

BUG: 371835

Test Plan

Created a desktop file with Icon=/home/foo/bar.svgz and it actually showed now

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 11187.Feb 10 2017, 7:45 PM
broulik retitled this revision from to [KStandardItemListWidget] Support QIcon from path in addition to fromTheme.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: emmanuelp, dfaure.
broulik set the repository for this revision to R318 Dolphin.
emmanuelp accepted this revision.Feb 11 2017, 11:15 AM
emmanuelp edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2017, 11:15 AM
elvisangelaccio added a subscriber: elvisangelaccio.EditedAug 9 2017, 9:28 PM

@broulik Any reason why this is not committed yet?

broulik abandoned this revision.Jan 23 2018, 1:32 PM

Should be obsolete with Qt 5.9 or 5.10 where svg icon isNull check is proper, I think.

Restricted Application added a subscriber: Dolphin. · View Herald TranscriptJan 23 2018, 1:32 PM

Revision Contents
Changeset List

Diff 11187

View Options

src/kitemviews/kstandarditemlistwidget.cpp

Loading...