Differential D4543

[ConfigModel] Emit dataChanged when a ConfigCategory changes
ClosedPublic
Actions

Authored by broulik on Feb 10 2017, 9:40 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R242:5becf5bc114e: [ConfigModel] Emit dataChanged when a ConfigCategory changes
Test Plan

Had a ConfigCategory whose visible was bound to a configuration, changed it, and the item appeared/disappeared at runtime.

Ideally, we signalled a change only for the role that actually changed but that'll blow thing up a lot and you hardly change the properties anyway

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 11150.Feb 10 2017, 9:40 AM
broulik retitled this revision from to [ConfigModel] Emit dataChanged when a ConfigCategory changes.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 10 2017, 9:40 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Feb 10 2017, 9:42 AM
hein accepted this revision.Feb 10 2017, 9:51 AM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Feb 10 2017, 9:51 AM
Closed by commit R242:5becf5bc114e: [ConfigModel] Emit dataChanged when a ConfigCategory changes (authored by broulik). · Explain WhyFeb 10 2017, 11:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasmaquick/configmodel.cpp (15 lines)

Diff 11158

View Options

src/plasmaquick/configmodel.cpp

Loading...