Differential D4518

Ungrab mouse in taskmanager context menu
ClosedPublic
Actions

Authored by anthonyfieroni on Feb 9 2017, 5:26 AM.

Details

Reviewers
davidedmundson
hein
broulik
Summary

In Qt 5.8, but i'm pretty sure i'm see it in Qt 5.7, ungrabMouse called in show() does not work (i don't know why).

Test Plan

Right click on task -> Start new instance -> mouse is still grabbed -> left click in taskmanager will activate element right clicked on it.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
anthonyfieroni updated this revision to Diff 11097.Feb 9 2017, 5:26 AM
anthonyfieroni retitled this revision from to Ungrab mouse in taskmanager context menu.
anthonyfieroni updated this object.
anthonyfieroni edited the test plan for this revision. (Show Details)
anthonyfieroni added reviewers: hein, davidedmundson, broulik.
anthonyfieroni set the repository for this revision to R119 Plasma Desktop.
anthonyfieroni added a subscriber: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 9 2017, 5:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein edited edge metadata.Feb 9 2017, 8:29 AM

Then maybe you can remove the call in show() ...?

anthonyfieroni updated this revision to Diff 11100.Feb 9 2017, 9:46 AM
anthonyfieroni edited edge metadata.
anthonyfieroni removed R119 Plasma Desktop as the repository for this revision.

Remove call to ungrabMouse in show()

anthonyfieroni updated this revision to Diff 11102.Feb 9 2017, 9:47 AM
anthonyfieroni set the repository for this revision to R119 Plasma Desktop.
hein accepted this revision.Feb 9 2017, 11:28 AM
hein edited edge metadata.
This revision is now accepted and ready to land.Feb 9 2017, 11:28 AM
anthonyfieroni added a comment.Feb 10 2017, 6:10 PM

Qt 5.8 has annoying bug, dismiss context menu by left clicking excatly over other window (not desktop or taskmanager) grabbing stays in taskmanager. I will investigate for workaround, if someone has a purpose i'll be happy :)

mvourlakos added a subscriber: mvourlakos.Feb 22 2017, 4:32 PM
In D4518#85123, @anthonyfieroni wrote:

Qt 5.8 has annoying bug, dismiss context menu by left clicking excatly over other window (not desktop or taskmanager) grabbing stays in taskmanager. I will investigate for workaround, if someone has a purpose i'll be happy :)

did you find a solution for this?

this must be also relevant to my report: https://bugreports.qt.io/browse/QTBUG-59044
is there any other qt ticket for this?

Revision Contents
Changeset List

Diff 11102

View Options

applets/taskmanager/package/contents/ui/ContextMenu.qml

Loading...