ScrollArea has a property for en/disabling the frame provided by its style. Until now the property wasn't evaluated, which besides making it impossible to deactivate the frame leaded to visual artifacts (in @hein's simple menu flashing frame at the bottom of the page list).
Details
Details
- Reviewers
mart hein - Group Reviewers
Plasma - Commits
- R242:eb39b3514130: [ScrollViewStyle] Evaluate frameVisible property
Tested with simple menu.
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
IIUI this means scroll indicators are now disabled by default unless a UI sets frameVisible: true? Marco, is this what you +1'd?
Comment Actions
Note: This patch changes the default. Since until now the frameVisible property wasn't evaluated the frames were always shown.
But since QtQuickControls ScrollView (i.e. Plasma Extra Components ScrollArea aswell) has set frameVisible to false by default, they are now not shown anymore.
Still it makes sense of course to evaluate the property.
Comment Actions
-1
I don't get the overflow indicator mark anywhere anymore since frameVisible is false by default for Plasma ScrollView.
Comment Actions
You mean in Plasma's ScrollArea? Would be ok for me. It's a rather random deviation from upstream's ScrollView though.
Is this ok for anyone else aswell?
Comment Actions
Set ScrollArea's frameVisible default to true additional in order to not change current implementations.
Comment Actions
Is there some danger in this when using the component with a different theme that has visible frames?
Should the scroll indicators be tied to frame visibility at all? That seems dubious to me.
Comment Actions
The scroll indicators are the frame component in the Breeze style. So they get replaced in any other style by the frame specified there. If you take a look at ScrollViewStyle.qml, the indicators are inside the frame component and the frame sides just change their opacity values
Comment Actions
Aye. I think that's weird, but I'm guessing the Breeze style had no choice there.
Does defaulting the frames to on mean the bottom flash is back too or is that still fixed?
Can't comment on the ramifications of defaulting it to on + other themes ...
Comment Actions
I agree.
Does defaulting the frames to on mean the bottom flash is back too or is that still fixed?
Still fixed.
Can't comment on the ramifications of defaulting it to on + other themes ...
Well, it should be pretty minimal. Because in general the frame component is obviously meant as a decoration only. The Plasma style changes this (maybe in a weird way) by being dependent on the scroll posibilities and therefore acting as a scrolling indicator.