[KFilePreviewGenerator] Add ignoreMaximumSize
AbandonedPublic

Authored by broulik on Feb 2 2017, 2:39 PM.

Details

Summary

This allows a user of this class to set the ignoreMaximumSize flag in the PreviewJobs used.

Test Plan

Dolphin has a logic where it will always ignore the maximum size for local files (isLocalFile or protocolClass == ":local"). This doesn't work in FolderView which uses this class to generate previews for its files.

The question on the other hand is whether we should just adopt this policy globally in PreviewJob itself instead.

Diff Detail

Repository
R241 KIO
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 10849.Feb 2 2017, 2:39 PM
broulik retitled this revision from to [KFilePreviewGenerator] Add ignoreMaximumSize.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: dfaure, emmanuelp, hein.
broulik set the repository for this revision to R241 KIO.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 2 2017, 2:39 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Feb 4 2017, 6:46 PM
dfaure edited edge metadata.
This revision is now accepted and ready to land.Feb 4 2017, 6:46 PM
broulik abandoned this revision.Jan 23 2018, 1:31 PM

This isn't really neccessary anymore as KIO ignores maximum size for :local consistently now.