Differential D4352

[ContainmentInterface] Use setSize instead of setWidth/setHeight in createApplet
ClosedPublic
Actions

Authored by broulik on Jan 30 2017, 2:51 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:031bd773b7c2: [ContainmentInterface] Use setSize instead of setWidth/setHeight in createApplet
Summary

This avoids needless binding updates and expensive layouting.

Test Plan

Together with D4351 this fixes task manager showing up with squashed delegates initially on plasma startup until it moves them into right position animated.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 10725.Jan 30 2017, 2:51 PM
broulik retitled this revision from to [ContainmentInterface] Use setSize instead of setWidth/setHeight in createApplet.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 30 2017, 2:51 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 30 2017, 3:01 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 30 2017, 3:01 PM
Closed by commit R242:031bd773b7c2: [ContainmentInterface] Use setSize instead of setWidth/setHeight in createApplet (authored by broulik). · Explain WhyJan 30 2017, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10727

View Options

src/scriptengines/qml/plasmoid/containmentinterface.cpp

Loading...