Differential D4156

sort alphabetically category list
ClosedPublic
Actions

Authored by mart on Jan 16 2017, 12:14 PM.

Details

Reviewers
leinir
Group Reviewers
Plasma
Commits
R304:6393cd598bb7: sort alphabetically category list
R304:bed0624b083a: Revert "if is not an archive, always copy"
Summary

sort the category list by their visible name
prefer sorting by displayName if available,
fallback to name otherwise

Test Plan

category dropdown still works and is sorted

Diff Detail

Repository
R304 KNewStuff
Branch
phab/sort
Lint
No Linters Available
Unit
No Unit Test Coverage
mart updated this revision to Diff 10222.Jan 16 2017, 12:14 PM
mart retitled this revision from to sort alphabetically category list.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added reviewers: Plasma, leinir.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 16 2017, 12:14 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Jan 16 2017, 5:13 PM
broulik added inline comments.
src/attica/atticaprovider.cpp
137

Use QCollator for locale-aware sorting

mart updated this revision to Diff 10274.Jan 17 2017, 8:46 AM
  • use QCollator
leinir accepted this revision.Jan 18 2017, 11:10 AM
leinir edited edge metadata.

LGTM :)

This revision is now accepted and ready to land.Jan 18 2017, 11:10 AM
Closed by commit R304:6393cd598bb7: sort alphabetically category list (authored by mart). · Explain WhyJan 18 2017, 11:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/attica/atticaprovider.cpp (6 lines)

Diff 10222

View Options

src/attica/atticaprovider.cpp

Loading...