Take into account protocol class when determining whether it's a local file for preview
AbandonedPublic

Authored by broulik on Jan 14 2017, 2:52 PM.

Details

Reviewers
emmanuelp
dfaure
Group Reviewers
Dolphin
Summary

This ensures that the maximum size is also ignored for e.g. desktop:/ URLs. Taken from PreviewJob.

Test Plan

I now get previews for large files on e.g. desktop:/ in Dolphin

I'm wondering if we should make this the default in PreviewJob instead of hardwiring a special logic of "always generate previews for local files" in Dolphin - this way also FolderView would benefit from this, which currently won't generate previews on desktop for > 5 MiB

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 10168.Jan 14 2017, 2:52 PM
broulik retitled this revision from to Take into account protocol class when determining whether it's a local file for preview.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Dolphin, emmanuelp, dfaure.
broulik set the repository for this revision to R318 Dolphin.
emmanuelp edited edge metadata.Feb 5 2017, 7:45 PM

I'm wondering if we should make this the default in PreviewJob

+1

Given PreviewJob now does the "right thing" by default, I think we can discard this.

Given PreviewJob now does the "right thing" by default, I think we can discard this.

+1

broulik abandoned this revision.Apr 24 2018, 2:45 PM