Don't let the sound indicator get as big as the task icon
AbandonedPublic

Authored by hein on Jan 11 2017, 7:11 PM.

Details

Reviewers
apol
jensreuterberg
Group Reviewers
Plasma
Summary

Otherwise it gets too relevant and takes some of the actual task prominence

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D4090
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 10068.Jan 11 2017, 7:11 PM
apol retitled this revision from to Don't let the sound indicator get as big as the task icon.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 11 2017, 7:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Can you make a screenshot? It's intentional, at least for regular task manager to be the same size. Icon tasks situation isn't ideal, though.

+1 for the verticalCenter change nonetheless, though

apol added a comment.Jan 11 2017, 7:15 PM

before


after

Just tried your patch, here it's so small I can hardly see it now.

What about reducing opacity to minimize the attention it draws?

apol added a comment.Jan 11 2017, 11:22 PM

Just tried your patch, here it's so small I can hardly see it now.

Should I try a different multiplier? 0.8 instead of 0.7...

What about reducing opacity to minimize the attention it draws?

I fear it would collide a bit with the color schemes... Besides we're already gray on gray.

hein added a subscriber: hein.Jan 12 2017, 7:45 AM

I'm against reducing opacity, using a fade-out for something that's "on" gets us into design trouble when we want to use fade out to say "off". I'm OK with reducing size a bit, but I also don't have a problem with the version on master personally. If we do resize size, I think we should try to make it the same size as our new tiny systray icons for a semblance of cohesion on the panel instead of reducing another new size class.

mart added a subscriber: mart.Jan 12 2017, 9:56 AM

I prefer reducing the size, and the screenshots here look ok to me (even those brousgt as an example of "barely visible")
if the icon never goes less than iconSizes.small, then semantically the size of the icon is always semantically correct
(if iconsizes.small is non visible on a particular device, then it's a problem of units scaling on dpi, not a taskbar problem)

applets/taskmanager/package/contents/ui/Task.qml
439 ↗(On Diff #10068)

to be onthe safe side:
Math.max(units.iconSizes.small, Math.min(units.iconSizes.medium, iconBox.width * 0.7))

if iconsizes.small is non visible on a particular device, then it's a problem of units scaling on dpi, not a taskbar problem

It's also super tiny on my non high dpi desktop

Log or squareroot?

mart added a comment.Jan 12 2017, 12:10 PM

so, let's keep 5.9 as is, and get sizing tought better for 5.10

apol added a comment.Jan 21 2017, 12:47 AM
In D4090#76737, @mart wrote:

so, let's keep 5.9 as is, and get sizing tought better for 5.10

So should I push to master?

hein added a comment.Jan 21 2017, 1:34 PM

After living it for a while I now agree that the indicators are too large, so I'd prefer this to go into 5.9.

I'm worried about the 0.7 magic number though. What does the systray do? The tray icons are much smaller than the audio indicators on my panel, and feel like they would be the right size. and be nice for consistency as mentioned.

apol updated this revision to Diff 10465.Jan 23 2017, 6:22 PM

Use marco's formula

apol marked an inline comment as done.Jan 23 2017, 6:23 PM

With this patch the icon is actually *bigger* now than it was before.

hein commandeered this revision.Jan 23 2017, 8:10 PM
hein added a reviewer: apol.

I've asked twice to look into using the tray's sizing logic; since it was being ignored I've just done it:

https://commits.kde.org/plasma-desktop/cd361efff2fb4eaf456a9f1186d795a869f45d51

Anchoring to parent.verticalCenter had already been done seperately by Kai.

hein abandoned this revision.Jan 23 2017, 8:10 PM

I think I can live with that.

hein added a comment.Jan 23 2017, 9:48 PM

Thanks! Sorry for straight committing, I was getting a bit grumpy ;)