1> Use applet only if application menu style is set to "Widget". If its not the case show a warning sign instead.
2> When applet is placed in a vertical panel force use the compact view.
and some minor changes.
davidedmundson | |
broulik |
1> Use applet only if application menu style is set to "Widget". If its not the case show a warning sign instead.
2> When applet is placed in a vertical panel force use the compact view.
and some minor changes.
Lint Skipped |
Unit Tests Skipped |
When applet is placed in a vertical panel force use the compact view.
Why? We can show the buttons below each other if the user wants to
applets/appmenu/lib/appmenuapplet.cpp | ||
---|---|---|
109 ↗ | (On Diff #9981) | I think update instead of set is better wording |
applets/appmenu/package/contents/config/main.xml | ||
13 ↗ | (On Diff #9981) | Can't you just use the plugin in the config dialog to avoid this config madness? |
applets/appmenu/package/contents/ui/main.qml | ||
71 ↗ | (On Diff #9981) | Don't use "emblem" icons - they are meant for "badges on top of files" for instance |
applets/appmenu/lib/appmenuapplet.cpp | ||
---|---|---|
44 ↗ | (On Diff #9981) | I was wondering if we can't just listen for the presence of the com.canonical.appmenu.regisrar service - if the user places an applet *and* has it on decoration, don't think that's too bad, it's a conscious thing? Not sure. |
applets/appmenu/lib/appmenuapplet.h | ||
---|---|---|
36 ↗ | (On Diff #9981) | Maybe "applicationMenuAppletEnabled" or something like that? |
applets/appmenu/package/contents/ui/main.qml | ||
76 ↗ | (On Diff #9981) | Please instead of a separate tooltip area set plasmoid.toolTipSubText, ie. above Plasmoid.toolTipSubText: !useApplet ? i18n("blabla") : "" |
I just noticed when I change the setting in the KCM the icon changes to the warning icon but the button stays enabled, only if I restart plasma the button is disabled
applets/appmenu/lib/appmenuapplet.h | ||
---|---|---|
69 ↗ | (On Diff #9981) | Needs to be a slot: public slots: void updateAppletEnabled(); that's why your connection doesn't work |
applets/appmenu/package/contents/ui/main.qml | ||
120 | Go to System Settings → Application Style → Fine Tuning (tab) to enable it. (I would still love if you could add a way for the user to open that KCM, perhaps in context menu?) | |
33 ↗ | (On Diff #9981) | Make it readonly property |
122 ↗ | (On Diff #9981) | Can we make it a binding instead of manually onFooChanged? |
applets/appmenu/package/contents/ui/main.qml | ||
---|---|---|
55 ↗ | (On Diff #9981) | A bit late to the party, but if this is the freedesktop name of an icon, then it should not have i18n. |