Details
- Reviewers
pgupta timotheegiet jjazeix rkaur - Group Reviewers
GCompris - Maniphest Tasks
- T1519: Port of Gtk+ Railroad activity
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Can you remove the temporary file .!1184!ActivityInfo.qml?
As it is a port, you need to also remove the 2 files in tools/ related to this activity.
bg.svg is not used also.
I think it would be nice to be able to drag the wagons on top to switch their places.
| src/activities/activities.txt | ||
|---|---|---|
| 12 ↗ | (On Diff #9847) | can you revert these changes unrelated to your activity? |
| 24 ↗ | (On Diff #9847) | can you revert these changes unrelated to your activity? |
| src/activities/railroad/ActivityInfo.qml | ||
| 28 ↗ | (On Diff #9847) | you can use: "Observe the train and then click on the items to set up a similar train" (http://gcompris.net/wiki/Voices_translation) |
| 29 ↗ | (On Diff #9847) | Memory-training |
| 30 ↗ | (On Diff #9847) | It's not a prerequisite ;). |
| 33 ↗ | (On Diff #9847) | it should be "discovery memory" else you don't have it in any category |
| 34 ↗ | (On Diff #9847) | can you update it to 8000? |
| src/activities/railroad/Railroad.qml | ||
| 65 | it's not an activity where you need to hide the bar. The bottom of your flow can be the top of the bar. This would also avoid to have the wagon on bottom left behind the bar button It's to be discussed with you and the other mentors, but it might be good to have a scrolling view instead of a fix Rectangle with 5 rows for the selection list so it would allow to keep the scaling of the image (because we won't force all the wagons to be in 5 rows but more). | |
| 83 | you should set sourceHeight instead of height. | |
| 103 | as said above, it's not really good to hide the bar, if you switch activity just after entering this one, the bar will disappear a few seconds later because of this | |
| 109 | I would not scale it when Activity.memoryMode === false | |
| src/activities/railroad/railroad.js | ||
| 32 | I would rename it to solutionArray or answerArray maybe | |
Scroll view added to the rows.
Quick Text added at game start.
Fixed previously reported issues.
Hi,
I tested quickly for the first time this activity in the branch with this patch added.
First thing I would say is the layout is not very good (at least on desktop), that can be improved.
Also, the way it's presented, it's not easy to understand the interaction to use it.
Maybe you have some ideas, please try to make something about those points.
The biggest issue I have with the layout is the way the instruction text area is at the top, masking the important thing to see... Better place it in the center of the screen in my opinion.
Then about the "game design", two things:
-it's not obvious at start that one has to click on the reference train to start... maybe also add an ok button on the center with the same action to get started.
-the order for adding the wagons isn't obvious.. personally, I think it's more logical to first add the 1st part (the locomotive/the engine), then add the first wagon connected to it, and so on in this order. I can see the way it works now can also be logical in the order to place them, but still I find it more confusing than the other way I described. Or maybe, solution could be to make the reference train in the other direction?
The introMessage is now updated. It now shows up below the reference train level.
Then about the "game design", two things:
-it's not obvious at start that one has to click on the reference train to start... maybe also add an ok button on the center with the same action to get started.
There are two ways to start -
- Direct click on the reference train to initiate the memory mode (if the user is confident, he has memorized the reference train arragement order)
- Wait for the reference train to move out of the screen (during this duration, the user is expected to memorize the reference train arrangement)
-the order for adding the wagons isn't obvious.. personally, I think it's more logical to first add the 1st part (the locomotive/the engine), then add the first wagon connected to it, and so on in this order. I can see the way it works now can also be logical in the order to place them, but still I find it more confusing than the other way I described. Or maybe, solution could be to make the reference train in the other direction?
Now the wagon are added from right -> left fashion anchored to left side of the screen.
Please test the latest commit
| src/activities/railroad/Railroad.qml | ||
|---|---|---|
| 83 | making it sourceHeight bars it from changing height dynamically on screen change | |
Hi, for this point I still think both solutions are at same time logical and confusing. Maybe we can just drag/drop the locomotives to the top row instead and do nothing on clicks?
Improvements:
- Drag/drop improved for top and lower section
- Timer added to let player have time to memorize and do swipe view before the train vanishes
- Intro message changed
- Swipe area provide in the top carriages section for user to view hidden ones in portrait mode
Hi, I tested the latest commit in your branch. There are improvements, but a few things can still be improved:
-Generally, it would be much better to not have the graphic items stretched, so they keep their original ratio and look better.
-On the grid of wagons, it's easy to trigger a slide of the line instead of picking a wagon. I think user shouldn't need to slide those lines.
-The grid should adapt to display a different number of lines and of items per lines depending on the screen ratio.