The official names are "byte order mark" and "Unicode".
Also consistently use "(BOM)" addition in UI actions/config entries,
helps people looking just for "BOM"
Details
Details
- Reviewers
dhaumann - Group Reviewers
Kate - Commits
- R39:3d7a514305e1: Fix "byte order marker" -> "byte order mark", use upper-case "Unicode" name
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Guess the wrong naming is my fault, fixing that is a good idea.
Perhaps for the mode line, just add the "byte-order-mark" as alternative (and keep the old one to be compatible)?
Comment Actions
For now just left the TODO comment, as I personally do not use kate tag lines (I know, I know), so cannot really judge how much pain it would become when working on same documents with old and new Kate apps/parts, where the new Kate uses "byte-order-mark" and the old ones does not know about it? If that is acceptable pain, just tell and I will give the needd code a try :)
Comment Actions
Two thinkgs:
- Please address the comments from Christoph and myself
- Please adapt in kate.git: kate/docs/
| src/document/katedocument.cpp | ||
|---|---|---|
| 4587 | Yes, please add backwards compatibility: } else if (var == QLatin1String("bom") || var == QLatin1String("byte-order-mark") || var == QLatin1String("byte-order-marker")) { | |
| src/variableeditor/variablelineedit.cpp | ||
| 161–162 | rename comment to "byte-order-mark" | |
| 161–162 | Rename to "byte-order-mark" | |
Comment Actions
Clicked "Submit" too fast.
Please adapt in kate.git: kate/docs/katepart/configuring.docbook: There, "byte-order-marker" appears two times, and need to be renamed to "byte-order-mark".