Differential D3943

Make sure we only initialize the appstream pool once
ClosedPublic
Actions

Authored by apol on Jan 4 2017, 1:20 AM.

Details

Reviewers
davidedmundson
broulik
Group Reviewers
Plasma
Commits
R120:17a706a917c3: Make sure we only initialize the appstream pool once
R119:6e1ca08eb9b4: Make sure we only initialize the appstream pool once

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 9679.Jan 4 2017, 1:20 AM
apol retitled this revision from to Make sure we only initialize the appstream pool once.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2017, 1:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mak added a subscriber: mak.Jan 4 2017, 1:41 AM

Looks good!
(appstreamPool is a bit verbose for my taste, AppStream interally calls it dpool (DataPooL) asPool or just pool - but that's just me being lazy and having to type too much n C anyways)

davidedmundson accepted this revision.Jan 5 2017, 11:47 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 5 2017, 11:47 PM
Closed by commit R119:6e1ca08eb9b4: Make sure we only initialize the appstream pool once (authored by apol). · Explain WhyJan 8 2017, 1:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/kicker/plugin/appentry.cpp (17 lines)

Diff 9833

View Options

applets/kicker/plugin/appentry.cpp

Loading...