Differential D3902

Fix X-Plasma-Drop* types
ClosedPublic
Actions

Authored by broulik on Jan 1 2017, 1:14 PM.

Details

Reviewers
davidedmundson
apol
Group Reviewers
Plasma
Commits
R242:a0f3d2429d0a: Fix X-Plasma-Drop* types
Summary

They are supposed to be lists. This fixes dropping folders on desktops to create a FolderView. Dropping trash:/ also offers to create a trash applet again. Don't know what else might have broken by this JSON migration...

BUG: 374418

Test Plan

X-Plasma-DropUrlPatterns is properly turned into a JSON array at build time but X-Plasma-DropMimeTypes is not and I have no idea why, ie. sticky note has two mime types but only gets a string (I tried both foo,bar and foo;bar; and foo;bar but neither works) so it is not offered for text documents

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9576.Jan 1 2017, 1:14 PM
broulik retitled this revision from to Fix X-Plasma-Drop* types.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, apol.
broulik set the repository for this revision to R242 Plasma Framework (Library).
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 1 2017, 1:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jan 1 2017, 7:32 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 1 2017, 7:32 PM
apol accepted this revision.Jan 2 2017, 2:42 AM
apol edited edge metadata.
Closed by commit R242:a0f3d2429d0a: Fix X-Plasma-Drop* types (authored by broulik). · Explain WhyJan 3 2017, 8:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9630

View Options

src/plasma/pluginloader.cpp

Loading...
View Options

src/scriptengines/qml/plasmoid/wallpaperinterface.cpp

Loading...