Adds the override keyword (and a ; to end the line properly).
Drops the virtual method, because it's redundant to override.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
+1 looks good!
I always use C++11 so I don't have to add override manually anymore.
codecompletion/context.cpp | ||
---|---|---|
162 | As you are using a regex anyway possibly "\\s*=\\s*0" instead? While unlikely e.g. a tab character could also appear there (and comments but that seems overkill). |
Comment Actions
Hm, what if you *don't* use C++11 in your code? It's still a fairly valid use-case.
Then adding a bogus 'override' every time is annoying.
This should be an optional feature, enabled based on whether this project allows C++11. Could be an option in the C++ project config page, or some other condition...
Comment Actions
@kfunk: the configuration already allows the user to change the standard, so we should be able to leverage that here and use the old syntax for c++98 projects.