[WIP] Fix logging category usage on Windows
ClosedPublic

Authored by vonreth on Dec 4 2016, 1:54 PM.

Details

Summary

Move defenition of logging category to a seperate file.
Untested on Linux, will probably break the build due to a missing include.

Diff Detail

Repository
R241 KIO
Branch
arcpatch-D3586_1
Lint
No Linters Available
Unit
No Unit Test Coverage
vonreth updated this revision to Diff 8741.Dec 4 2016, 1:54 PM
vonreth retitled this revision from to [WIP] Fix logging category usage on Windows.
vonreth updated this object.
vonreth edited the test plan for this revision. (Show Details)
vonreth added a reviewer: sandsmark.
vonreth added a subscriber: mutlaqja.
leinir accepted this revision.Dec 6 2016, 1:27 PM
leinir added a reviewer: leinir.
leinir added a subscriber: leinir.

Builds very nicely on linux (i understand that was unknown). It could be achieved simply by copying the declaration/definition calls into the windows source as well, but of course that would potentially yield problematic results in the shape of missed symbols and whatnot if a future change required the category to change name or something like that, so... yeah, this works :)

This revision is now accepted and ready to land.Dec 6 2016, 1:27 PM
kfunk accepted this revision.Dec 6 2016, 1:36 PM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Rest LGTM, but please rename the files

src/ioslaves/trash/kiotrashlogging.cpp
1 ↗(On Diff #8741)

Per convention these files are usually suffixed with debug.h/debug.cpp

kfunk added inline comments.Dec 6 2016, 1:38 PM
src/ioslaves/trash/kiotrashlogging.cpp
1 ↗(On Diff #8741)

Okay, I see that a few other frameworks also use 'logging' as suffix. Though 'debug' seems to be used in kio.git at least. Change at will.

vonreth updated this revision to Diff 8812.Dec 6 2016, 3:32 PM

Apply changes suggestd by Kevin

vonreth updated this revision to Diff 8813.Dec 6 2016, 3:36 PM

Fix commit message

This revision was automatically updated to reflect the committed changes.