Move defenition of logging category to a seperate file.
Untested on Linux, will probably break the build due to a missing include.
Details
Details
- Reviewers
kfunk leinir sandsmark - Group Reviewers
Frameworks - Commits
- R241:d5bf2083ee2e: Fix logging category usage on Windows
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- arcpatch-D3586_1
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Builds very nicely on linux (i understand that was unknown). It could be achieved simply by copying the declaration/definition calls into the windows source as well, but of course that would potentially yield problematic results in the shape of missed symbols and whatnot if a future change required the category to change name or something like that, so... yeah, this works :)
Comment Actions
Rest LGTM, but please rename the files
src/ioslaves/trash/kiotrashlogging.cpp | ||
---|---|---|
1 ↗ | (On Diff #8741) | Per convention these files are usually suffixed with debug.h/debug.cpp |
src/ioslaves/trash/kiotrashlogging.cpp | ||
---|---|---|
1 ↗ | (On Diff #8741) | Okay, I see that a few other frameworks also use 'logging' as suffix. Though 'debug' seems to be used in kio.git at least. Change at will. |