As discussed on plasma-devel [1]. See https://phabricator.kde.org/D4690
This bumps the minimum KF5 version to 5.32
[1]: https://mail.kde.org/pipermail/plasma-devel/2016-November/061750.html
BUG: 371825
FIXED-IN: 5.10
davidedmundson |
Plasma |
As discussed on plasma-devel [1]. See https://phabricator.kde.org/D4690
This bumps the minimum KF5 version to 5.32
[1]: https://mail.kde.org/pipermail/plasma-devel/2016-November/061750.html
BUG: 371825
FIXED-IN: 5.10
Still builds.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
5.29 is in only a few days, that's way too close for a change this massive.
Especially one that requires a lot of distribution co-ordination as we're creating installation conflicts.
Whilst I support this change in general, I don't want to see it going into 5.29.
Other than that, this part of the change is all good.
Speaking as a distro person: this might cause issues. The reason is that *if* we update to KF 5.29 (or 30) with this and Plasma stays as a stable version, we will get interesting conflicts.
And of course, removing this in a stable version is not an option.
CMakeLists.txt | ||
---|---|---|
7–8 | You can't do this, framework version is bumped by release script automatically, so when you push this there is no 5.30.0 version of KIO. Which will make it fail, you need to bump version once frameworks 5.30 is relased. |
CMakeLists.txt | ||
---|---|---|
7–8 | Yep, this will be pushed only after 5.30 gets released |