Differential D3393

Make compile against WinXP SDK
AbandonedPublic
Actions

Authored by kfunk on Nov 16 2016, 10:03 PM.

Details

Reviewers
arichardson
Group Reviewers
Frameworks
Commits
R241:61f3c9fef7a5: Make compile against WinXP SDK
Summary

CreateSymbolicLinkW function is only available since Windows Vista

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
kfunk updated this revision to Diff 8238.Nov 16 2016, 10:03 PM
kfunk retitled this revision from to Make compile against WinXP SDK.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
dhaumann added a subscriber: dhaumann.Nov 17 2016, 10:02 AM

In general ok (but why is this a review request for KSyntaxHighlighting?)

src/core/kioglobal_p_win.cpp
87

Or should it just return false in this case?

kfunk edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting.Nov 17 2016, 10:23 AM
In D3393#63437, @dhaumann wrote:

In general ok (but why is this a review request for KSyntaxHighlighting?)

Because the reviewers field auto-completion sucks :)

kfunk planned changes to this revision.Nov 18 2016, 12:52 PM
kfunk added inline comments.
src/core/kioglobal_p_win.cpp
87

Thinking about it, yep, probably better that way. Will update the patch.

kfunk added a comment.Jan 17 2017, 7:31 AM

This has been pushed:

commit 61f3c9fef7a5ca1a952e7681f5d37b7a9f0689c4
Author: Kevin Funk <kfunk@kde.org>
Date:   Wed Nov 16 23:02:33 2016 +0100

    Make compile against WinXP SDK
kfunk abandoned this revision.Jan 17 2017, 7:31 AM

Revision Contents
Changeset List

PathPackages
Msrc/core/kioglobal_p_win.cpp (4 lines)

Diff 8238

View Options

src/core/kioglobal_p_win.cpp

Loading...