Move glx version check functionality to platform plugin
ClosedPublic
Actions

Authored by graesslin on Nov 10 2016, 2:09 PM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

Summary

Glx version is only required once in the standalone x11 platform. No
need to have that in the shared kwinglutils library.

Removes one xlib usage from shared kwin.

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to Move glx version check functionality to platform plugin.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

broulik added inline comments.

plugins/platforms/x11/standalone/glxbackend.cpp
253	Just fyi: QVersionNumber is public since Qt 5.6

With @broulik 's comment addressed.. +1

This revision is now accepted and ready to land.Nov 16 2016, 6:37 AM

In D3329#62981, @bshah wrote:

With @broulik 's comment addressed.. +1

for the record: I'm not going to port the code to QVersionNumber. Internally KWin has the kVersionNumber which is used quite a lot in the code base.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libkwineffects/kwinglutils.h (1 line)
M			libkwineffects/kwinglutils.cpp (12 lines)
M			plugins/platforms/x11/standalone/glxbackend.h (1 line)
M			plugins/platforms/x11/standalone/glxbackend.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8072	4f4d9d5		Nov 10 2016, 2:09 PM	★	★
Diff 2	8191	3041b87	rKWIN5d39da84277fd677f96d1b51df93571abd160c45	Nov 16 2016, 6:47 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
007bd6a479bd	4c029c3946c2	4f4d9d5cfe40	Martin Gräßlin	Move glx version check functionality to platform plugin (Show More…)	Nov 10 2016, 2:07 PM

Status	Author	Revision
Closed	graesslin	D3337 Remove KWin::display from kwinglobals
Closed	graesslin	D3336 Pass function ptr to resolve glFunctions to initGL
Closed	graesslin	D3335 Move resolving glxSwapIntervalMesa into platform plugin
Closed	graesslin	D3332 Move querying glx extensions into the platform plugin
Closed	graesslin	D3329 Move glx version check functionality to platform plugin