Move querying glx extensions into the platform plugin
ClosedPublic

Authored by graesslin on Nov 10 2016, 3:02 PM.

Details

Summary

Glx extensions are only interesting to the glxbackend. Given that
querying can be moved there.

In order to simplify the extensions can be stored in the OpenGLBackend
which also provides the convenience check as before.

The egl platforms should also be adjusted to query in that way and
remove it from the kwinglutils.

There is still a usage of the glxextensions inside kwinglutils to
resolve one function. That should also be moved into the platform.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8076.Nov 10 2016, 3:02 PM
graesslin retitled this revision from to Move querying glx extensions into the platform plugin.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptNov 10 2016, 3:02 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Nov 10 2016, 3:39 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Nov 10 2016, 3:39 PM
broulik added inline comments.
scene_opengl.h
648

QVector?

graesslin added inline comments.Nov 11 2016, 6:32 AM
scene_opengl.h
648

yes and no. I would love to use QVector here and that was what I wanted to use in the first place. But it will always be filled from a QByteArray::split and that returns a QList<QByteArray>. So I don't think we gain much if we convert this into a QVector.

This revision was automatically updated to reflect the committed changes.