Otherwise we have a gap during load (waiting querying kactivities))
between screen pool being created and us connecting to the screen
changed signals, which in turn are used to update screen pool.
In particular the primary screen can get out of sync between the current
state and the screen pool.
Based on Christopher Feck's research and initial patch
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I confirm it fixes my issue (bug 366187), both with removed plasma* config files, as well as with my actual config files.
A quick question: This changes what the ScreenPool constructor does, are there any potential users of ScreenPool that now miss a call to ->load(), as it was done implicitly before? Wouldn't it be safer to call load() in the constructor as well?
| shell/screenpool.cpp | ||
|---|---|---|
| 37 | This line does nothing. What was the intention? | |
shellcorona should be the only user so far, so that shouldn't be an issue
even just constructing screenpool later, should be fine
| shell/screenpool.cpp | ||
|---|---|---|
| 37 | i guess was to reset it, so would be m_primaryConnector.clear() or something? | |