Differential D3299

Let KPackage know about X-Plasma-RootPath
ClosedPublic
Actions

Authored by apol on Nov 7 2016, 3:18 PM.

Details

Reviewers
lbeltrame
mart
Group Reviewers
Frameworks
Commits
R290:cedb740e8f36: Let KPackage know about X-Plasma-RootPath
Summary

This way any KPackage can inherit another one, regardless of them
being Plasma Packages or not.
This fixes ::isValid calls within kpackagetool5 on packages that
use this variable.

Test Plan

tests pass, this warning is not visible anymore when configuring
kdeplasma-addons

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 7982.Nov 7 2016, 3:18 PM
apol retitled this revision from to Let KPackage know about X-Plasma-RootPath.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Frameworks, lbeltrame, mart.
mart accepted this revision.Nov 8 2016, 11:47 AM
mart edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2016, 11:47 AM
apol closed this revision.Nov 8 2016, 2:47 PM

Revision Contents
Changeset List

PathPackages
Msrc/kpackage/package.cpp (17 lines)

Diff 7982

View Options

src/kpackage/package.cpp

Loading...