I just want to open the discussion if we can change things in panelview ...

I have in my mind also a variable to disable borders(shadows) when a panel has set NoBackground as backgroundHint

with that variable I can also disable the shadows for the panel by adding in panelview.cpp,

void PanelView::updateEnabledBorders()
{
    Plasma::FrameSvg::EnabledBorders borders = Plasma::FrameSvg::AllBorders;
    
    if (!m_effects) {
       borders = Plasma::FrameSvg::NoBorder;
    }

I think NoBackground should just do this - this would also be consistent with Plasma Dialog where disabling the standard background turns off everything.

In D3282#61060, @broulik wrote:

I think NoBackground should just do this - this would also be consistent with Plasma Dialog where disabling the standard background turns off everything.

do you know a way for panelview to access the containment.backgroundHints ? (from the AppletInterface in order to achieve what you are proposing)

I think NoBackground should just do this - this would also be consistent with Plasma Dialog where disabling the standard background turns off everything.

I would 100% agree, but the difference between panel and dialog is that dialog draws the frame background, panel doesn't.

So "just doing it" still means changing two pieces of code in two repos to be in sync, at which point an explicit API (this patch) is probably the cleaner option.

i prefer this to be based onto containment.backgroundhits as well, i don't like explicit api for this at all.
so not having a background would remove the frame background *and* disable the effects

so not having a background would remove the frame background *and* disable the effects

That is the proposal here also.

The difference is whether Panel.qml connects to AppletInterface *and* PanelView connects to AppletInterface.
Or Panel.qml connects to AppletInterface and then Panel.qml tells PanelView what effect to do
.
From a conusmer POV it'll be exactly the same.

Code wise, it's much more awkward to do the first one as it needs to go through the property(_graphicsObject)<AppletInterface>() malarky.

In D3282#61310, @davidedmundson wrote:

From a conusmer POV it'll be exactly the same.

Code wise, it's much more awkward to do the first one as it needs to go through the property(_graphicsObject)<AppletInterface>() malarky.

yeah, i kinda wish panelview painted its own framesvg like Dialog..

even if not changing anything about the architecture, I think if even if not 100% technically correct, the api would sound better with the effects property actually replaced with backgroundhits like the applet (or even a drawsownbackground bool, but would prefer actually using backgroundhits). The implmentation would stay as is

a transparent Now Dock panel with Blur Effect enabled for Plasma

In D3282#61326, @mart wrote:

even if not changing anything about the architecture, I think if even if not 100% technically correct, the api would sound better with the effects property actually replaced with backgroundhits like the applet (or even a drawsownbackground bool, but would prefer actually using backgroundhits). The implmentation would stay as is

I will wait for the discussion to conclude in this...
I suppose there are three ideas:

1. keep "effects variable
2. replace "effects" variable with backgroundHints one of type Plasma::Applet::BackgroundHint
3. rename "effects" variable to drawsownbackground

I could try (2) but I will wait first for your confirmation....
In the qml part there would be then a "panel.backgroundHints" variable to use instead of "panel.effects"...

Thank u!!!

Unfortunately I dont have commit access yet.. I am going to request a developer acount afterwards...
Is it possible for someone to commit this patch and D3283?

this has been commited !!!