Differential D3283

Hide Background for Panel when backgroundHints are used
ClosedPublic
Actions

Authored by mvourlakos on Nov 6 2016, 5:07 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

a Panel can set,

Plasmoid.backgroundHints: PlasmaCore.Types.NoBackground;

in order to become transparent

this patch is using D3282 in order to work

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
mvourlakos updated this revision to Diff 7944.Nov 6 2016, 5:07 PM
mvourlakos retitled this revision from to Hide Background for Panel when backgroundHints are used.
mvourlakos updated this object.
mvourlakos edited the test plan for this revision. (Show Details)
mvourlakos added reviewers: Plasma, davidedmundson.
mvourlakos set the repository for this revision to R119 Plasma Desktop.
mvourlakos added a project: Plasma.
mvourlakos added a subscriber: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptNov 6 2016, 5:07 PM
davidedmundson edited edge metadata.Nov 7 2016, 9:16 AM

Cool, but doesn't this also need the binding mentioned in D3282 ?

mart added a subscriber: mart.Nov 7 2016, 1:37 PM

+1, tough D3282 should use containment.backgroundHints as well

mvourlakos added a comment.Nov 7 2016, 2:49 PM
In D3283#61170, @davidedmundson wrote:

Cool, but doesn't this also need the binding mentioned in D3282 ?

yes it does, I can update the patch but I am waiting the discussion in D3282 to conclude
because D3283 and D3282 need each other

mvourlakos updated this revision to Diff 8049.Nov 9 2016, 5:28 PM
mvourlakos updated this object.
mvourlakos edited edge metadata.

updated the code for the new backgroundHints from D3282

davidedmundson accepted this revision.Nov 11 2016, 4:28 PM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Nov 11 2016, 4:28 PM
mvourlakos added a comment.Nov 13 2016, 6:03 PM

this has been committed!!!

Revision Contents
Changeset List

Diff 8049

View Options

desktoppackage/contents/views/Panel.qml

Loading...