Proofread/update kfind docbooks
ClosedPublic

Authored by lueck on Nov 5 2016, 10:00 PM.

Details

Summary

handbook

remove ENTITY kappname

man page

remove "a colon separated path", this does not work for me in kf5 master compiled from sources
add kf5options + qt5options to refsect1 "See Also"

Let me explain why I removed "a colon separated path", and what does not work for me starting kfind in konsole:

  1. "kfind /tmp:/home" -> Look in: prefilled with "file:///tmp:/home"
  2. "kfind +/tmp" -> Look in: prefilled with "file:///path/to/startdir/+/tmp"

If I start the search 1) or 2) I get a dialog saying "Could not find the specified folder."

kfind/kfinddlg.cpp-208- else if (errorCode == KIO::ERR_DOES_NOT_EXIST)
kfind/kfinddlg.cpp-209- {
kfind/kfinddlg.cpp-210- setStatusMsg(i18n("Error."));
kfind/kfinddlg.cpp:211: KMessageBox::sorry( this, i18n("Could not find the specified folder."));

Test Plan

builds

Diff Detail

Repository
R228 KFind
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck updated this revision to Diff 7933.Nov 5 2016, 10:00 PM
lueck retitled this revision from to Proofread/update kfind docbooks.
lueck updated this object.
lueck edited the test plan for this revision. (Show Details)
lueck added reviewers: broulik, Documentation.
lueck set the repository for this revision to R228 KFind.
lueck added a comment.Nov 29 2016, 3:20 AM

Please review

Ping! the changes are fine by me; @broulik, do you have any additional comment for this (initial?) set of fixes?

aacid accepted this revision.Jan 10 2017, 12:45 AM
aacid added a reviewer: aacid.
aacid added a subscriber: aacid.

If Kai doesn't have anything else to add i'd say let's just get this in and maybe improve what needs to be improved later?

This revision is now accepted and ready to land.Jan 10 2017, 12:45 AM
broulik accepted this revision.Jan 16 2017, 5:33 PM
broulik edited edge metadata.

Sorry, I totally missed that review.

Looks like a QUrl porting error/oversight - not that I ever used this although I knew it must have existed.

Sorry, I totally missed that review.

Looks like a QUrl porting error/oversight - not that I ever used this although I knew it must have existed.

Do you mean that you are going to fix it (or that at least a bug is needed to trace this issue)?

Yeah, can you please file a bug report. I'll have a look when I find time, not that I ever used this, though. There were quite a few porting errors in KFind (missing tilde expansion, unable to deal with URLs without file:// etc) so doesn't surprise me there's more stuff broken.

lueck added a comment.Jan 23 2017, 6:49 AM

Sorry, I totally missed that review.

Looks like a QUrl porting error/oversight - not that I ever used this although I knew it must have existed.

I just tried KFind 2.0 Qt 3.3.8c KDE 3.5.10 "release 83" and kfind 2.0 Qt 4,8,8 KDE 4.14.2 in VMs and seaching with colon separated paths does not work also.
So no porting error, this feature probably never worked since ages

This revision was automatically updated to reflect the committed changes.