Differential D3130

Improve Activity Pager Layout for horizontal and vertical cases
ClosedPublic
Actions

Authored by mvourlakos on Oct 21 2016, 2:43 PM.

Details

Reviewers
mart
hein
Group Reviewers
Plasma
Summary

this patch fixes also #367990

The activity pager is currently using the virtual desktops layout.
This patch creates a new config option called pagerLayout and provides to the user the following layout options: Default, Horizontal, Vertical

Test Plan

I added in the desktop both VDs pager and the Activity Pager and everything worked correctly and without interfer with each other in their layouts.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
mvourlakos updated this revision to Diff 7596.Oct 21 2016, 2:43 PM
mvourlakos retitled this revision from to Improve Activity Pager Layout for horizontal and vertical cases.
mvourlakos updated this object.
mvourlakos edited the test plan for this revision. (Show Details)
mvourlakos added reviewers: Plasma, hein.
mvourlakos set the repository for this revision to R119 Plasma Desktop.
mvourlakos added a project: Plasma.
mvourlakos added a subscriber: mvourlakos.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptOct 21 2016, 2:43 PM
mvourlakos updated this revision to Diff 7602.Oct 22 2016, 8:51 AM
mvourlakos updated this object.

updated the diff in order to correspond correctly...

ivan added a reviewer: mart.Oct 24 2016, 4:37 PM
hein requested changes to this revision.Oct 24 2016, 4:58 PM
hein edited edge metadata.
hein added inline comments.
applets/pager/package/contents/ui/main.qml
196

There's a lot of small coding style nits like no spaces around = here or no space after 'if' all throughout the patch - please clean that up a little bit.

199

Please add comments like /* Horizontal */ into the conditions for readability (I wish we could generate proper enums from config ...).

This revision now requires changes to proceed.Oct 24 2016, 4:58 PM
mvourlakos updated this revision to Diff 7641.Oct 24 2016, 6:22 PM
mvourlakos edited edge metadata.

updated in needed changes

hein accepted this revision.Oct 24 2016, 9:10 PM
hein edited edge metadata.

Do you have commit access?

This revision is now accepted and ready to land.Oct 24 2016, 9:10 PM
mvourlakos marked 2 inline comments as done.Oct 24 2016, 9:12 PM
In D3130#58604, @hein wrote:

Do you have commit access?

unfortunately not yet...
this is my first patch for plasma...

applets/pager/package/contents/ui/main.qml
199

Hein, is there a way in QML to generate proper enums from config?

davidedmundson added a subscriber: davidedmundson.Oct 24 2016, 9:13 PM
davidedmundson added inline comments.
applets/pager/package/contents/ui/main.qml
199

there is not (currently)

hein added a comment.Oct 24 2016, 9:32 PM

Good showing then :)

I'll commit for you (with your name); make sure to consider applying for dev access a couple of patches in. Check out Plasma on freenode IRC, too!

mvourlakos marked an inline comment as done.Oct 24 2016, 9:37 PM
In D3130#58614, @hein wrote:

Good showing then :)

I'll commit for you (with your name); make sure to consider applying for dev access a couple of patches in. Check out Plasma on freenode IRC, too!

:), thanks a lot Hein!
I will send two-three patches more and then apply for dev access...

Revision Contents
Changeset List

Diff 7641

View Options

applets/pager/package/contents/config/main.xml

Loading...
View Options

applets/pager/package/contents/ui/configGeneral.qml

Loading...
View Options

applets/pager/package/contents/ui/main.qml

Loading...