Details
- Reviewers
mart hein - Group Reviewers
Plasma - Commits
- R119:e69643e039f0: Replaced the launcher pinning action with a per-activity meny
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
What happens if there is only one activity? I don't use activities and I don't want a complicated submenu for pinning applications in this case.
| applets/taskmanager/package/contents/ui/ContextMenu.qml | ||
|---|---|---|
| 416 | Imho this should be a regular function() like the others | |
| 418 | Don't you keep adding a connection everytime you call refresh()? | |
| 425 | result.checked = activities.some(function(activity) {
return activity === id
}) | |
| 440 | runningActivities.forEach(function(activity) {
createNewItem(activity, name, ...)
}) | |
probably in that case there should be the simple "add launcher when not running"
now, i don't know wether that action should add to the current or to all of them.
to all is probably safest for new users
probably in that case there should be the simple "add launcher when not running"
Yes, and adding to all activities would be the smartest choice I'd say.
> probably in that case there should be the simple "add launcher when not running"
Yes, and adding to all activities would be the smartest choice I'd say.
+1
- Created a special case for when there is only one activity
| applets/taskmanager/package/contents/ui/ContextMenu.qml | ||
|---|---|---|
| 416 | I didn't want to pollute the outside world - it should be as efficient as if it was a regular function (if qt jit is sane - it could even be inlined). | |
| 418 | Fixed | |
| 425 | Thanks for this. The last time I tried 'modern' JS features in Qt, they did not work, and I stopped re-testing. It is nice to know this works, JS is a bit less ugly now ;) | |