Fix drawing QtQuickControls ComboBox popups
AbandonedPublic
Actions

Authored by drosca on Oct 14 2016, 1:42 PM.

Details

Reviewers

hpereiradacosta
broulik

Group Reviewers

Plasma

Summary

Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
Adaptation of the same commit from Breeze, but here it was needed
to also bring some helper functions from Breeze.

BUG: 370733
FIXED-IN: 5.8.2

Test Plan

Text is readable with all color schemes now.

Diff Detail

Repository

R113 Oxygen Theme

Branch

Plasma/5.8

Lint

No Linters Available

Unit

No Unit Test Coverage

drosca updated this revision to Diff 7393.Oct 14 2016, 1:42 PM

drosca retitled this revision from to Fix drawing QtQuickControls ComboBox popups.

drosca updated this object.

drosca edited the test plan for this revision. (Show Details)

drosca added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptOct 14 2016, 1:42 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

drosca edited the test plan for this revision. (Show Details)Oct 14 2016, 1:43 PM

drosca added reviewers: broulik, hpereiradacosta.

Well, that works, of course, but in principle, copying the helper functions from breeze should not be necessary. Oxygen should have everything instrumented already, and using the 'correct' oxygen mixing of colors, frame radius, etc, as opposed to breeze' ones.
Let me have a look ...

any news on this? </janitor mode>

In D3057#61334, @mart wrote:

any news on this? </janitor mode>

nope unfortunately
busy with other stuff
(but the patch is not satisfactory: just copying code from breeze is not the solution, most of the code should already be present, though in a slightly differnet form, in oxygen ...)

drosca abandoned this revision.Nov 7 2016, 2:02 PM