Differential D3035

Add request to have focus in a PlasmaShellSurface of Role Panel
ClosedPublic
Actions

Authored by graesslin on Oct 12 2016, 12:43 PM.

Details

Reviewers

sebas

Group Reviewers

Plasma on Wayland

Commits

R127:ee3f47a597f7: Add request to have focus in a PlasmaShellSurface of Role Panel

Summary

By default a panel does not take focus. But there are panels which
should get keyboard focus. Examples in a Plasma session are the widget
explorer.

This change adds a new request to PlasmaShell interface to specify
whether a panel should get focus. The compositor can use this request to
decide whether to pass focus to a panel.

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 7343.Oct 12 2016, 12:43 PM

graesslin retitled this revision from to Add request to have focus in a PlasmaShellSurface of Role Panel.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma on Wayland.

Restricted Application added a project: Plasma on Wayland. · View Herald TranscriptOct 12 2016, 12:43 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

graesslin added a dependency: D3007: Add auto-hiding panel support to PlasmaShellSurface interface.Oct 12 2016, 12:43 PM

Fix unit test

graesslin added a dependent revision: D3036: Support forceActiveWindow for Panels.Oct 12 2016, 12:51 PM

graesslin added a dependent revision: D3037: Support docks which take input.Oct 12 2016, 1:13 PM

graesslin added a dependent revision: D3038: [krunner] Make KRunner on Wayland a Panel.Oct 12 2016, 2:47 PM

romangg added a subscriber: romangg.Oct 15 2016, 11:00 PM

romangg added inline comments.

src/client/protocols/plasma-shell.xml
373	Use another name instead of "skip" (copy paste from set_skip_taskbar) ?
src/server/plasmashell_interface.cpp
90	Name "skip" of argument like in line 373.

Other than @subdiff 's comment, it looks good to me.

src/client/protocols/plasma-shell.xml
373	"takes_focus" perhaps?

This revision is now accepted and ready to land.Oct 16 2016, 2:46 PM

graesslin marked 3 inline comments as done.Oct 18 2016, 5:46 AM

Closed by commit R127:ee3f47a597f7: Add request to have focus in a PlasmaShellSurface of Role Panel (authored by graesslin). · Explain WhyOct 18 2016, 5:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/client/test_plasmashell.cpp (24 lines)
M			src/client/plasmashell.h (11 lines)
M			src/client/plasmashell.cpp (5 lines)
M			src/client/protocols/plasma-shell.xml (11 lines)
M			src/server/plasmashell_interface.h (10 lines)
M			src/server/plasmashell_interface.cpp (18 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7343	7a1c273		Oct 12 2016, 12:43 PM	★	★
Diff 2	7344	7a1c273	Fix unit test	Oct 12 2016, 12:46 PM	★	★
Diff 3	7482	e772a3e	rKWAYLANDee3f47a597f7293cb8970d0405b38bd4adcb7988	Oct 18 2016, 5:47 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
3d63deea6211	2c1a7019a4aa	7a1c2733f70a	Martin Gräßlin	Add request to have focus in a PlasmaShellSurface of Role Panel (Show More…)	Oct 12 2016, 12:40 PM

Status	Author	Revision
Closed	graesslin	D3080 Panel auto hide support for Wayland panels
Closed	bshah	D3084 [shell] Support autohide panel on wayland
Closed	graesslin	D3036 Support forceActiveWindow for Panels
Closed	graesslin	D3037 Support docks which take input
Closed	graesslin	D3038 [krunner] Make KRunner on Wayland a Panel
Closed	graesslin	D3035 Add request to have focus in a PlasmaShellSurface of Role Panel
Closed	graesslin	D3007 Add auto-hiding panel support to PlasmaShellSurface interface