enriquem (Enrique Melendez)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 10 2018, 4:08 PM (87 w, 2 d)
Availability
Available

Recent Activity

Sun, Aug 2

enriquem added a comment to D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS.

Done. Find at https://invent.kde.org/frameworks/networkmanager-qt/-/merge_requests/2

Sun, Aug 2, 11:27 AM · Frameworks

Sat, Aug 1

enriquem requested review of D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS.
Sat, Aug 1, 10:12 AM · Frameworks

Jan 26 2020

enriquem updated the diff for D26930: The command-line option --fullscreen is not honored unless there is also a URL. Besides, when providing --fullscreen and multiple URLs, all of them are connected in fullscreen mode.

Changed the help message

Jan 26 2020, 5:32 PM
enriquem updated the summary of D26930: The command-line option --fullscreen is not honored unless there is also a URL. Besides, when providing --fullscreen and multiple URLs, all of them are connected in fullscreen mode.
Jan 26 2020, 5:29 PM
enriquem added a comment to D26930: The command-line option --fullscreen is not honored unless there is also a URL. Besides, when providing --fullscreen and multiple URLs, all of them are connected in fullscreen mode.

Feel free to drop this you think it is not useful. Not a very important development.

Jan 26 2020, 5:20 PM
enriquem requested review of D26930: The command-line option --fullscreen is not honored unless there is also a URL. Besides, when providing --fullscreen and multiple URLs, all of them are connected in fullscreen mode.
Jan 26 2020, 5:19 PM
enriquem added a comment to D26917: Handle a crash in full screen requests when the window shows no host list .

Thanks for the investigation! There are more places where m_addressInput is used without a nullptr check, but I didn't analyze the code flow if these can be reached when the m_addressInput widget is not present. Feel free to verify :)

Jan 26 2020, 5:15 PM

Jan 25 2020

enriquem added a reviewer for D26917: Handle a crash in full screen requests when the window shows no host list : uwolfer.
Jan 25 2020, 2:56 PM
enriquem updated the summary of D26917: Handle a crash in full screen requests when the window shows no host list .
Jan 25 2020, 2:53 PM
enriquem requested review of D26917: Handle a crash in full screen requests when the window shows no host list .
Jan 25 2020, 2:52 PM

May 26 2019

enriquem added a comment to D21296: Add the option to configure the realm.

Looks good.

May 26 2019, 11:37 AM · Plasma

May 19 2019

enriquem requested review of D21296: Add the option to configure the realm.
May 19 2019, 7:20 PM · Plasma

May 15 2019

enriquem abandoned D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time.
May 15 2019, 10:31 AM · Plasma

May 2 2019

enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

I addressed your comments. Sorry for the careless coding in what spaces are concerned. BTW, I added a missing QStringLiteral.

May 2 2019, 7:03 PM · Plasma

Apr 30 2019

enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

I believe I addressed all of your comments. Please check your email for testing options.

Apr 30 2019, 9:29 PM · Plasma

Apr 7 2019

enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

Update per comments above

Apr 7 2019, 9:28 PM · Plasma
enriquem added a comment to D18394: Add OTP support for openconnect VPN.

! In D18394#445411, @jgrulich wrote:

Apr 7 2019, 9:27 PM · Plasma
enriquem added inline comments to D18394: Add OTP support for openconnect VPN.
Apr 7 2019, 12:04 PM · Plasma
enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

Hopefully there are no more trailing spaces.

Apr 7 2019, 12:02 PM · Plasma
enriquem added a comment to D18394: Add OTP support for openconnect VPN.
  1. I'm not sure if the UI for openconnect tokens is correct, I think the QLineEdit for token secret should be on the same line, and you should probably use PasswordField instead? It can be our PasswordField widget from libs/editor/widgets/. Or it's not secret in the same sense as other secrets and it will not need to be saved by secret agent, like rest of passwords? I would also follow nm-connection-editor and make tokens options visible in the main UI, not under specific button.
Apr 7 2019, 11:44 AM · Plasma

Mar 6 2019

enriquem abandoned D17487: Check if the form has changed, and only reconnect if it has.
Mar 6 2019, 4:17 PM · Plasma

Mar 5 2019

enriquem added a comment to D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time.

Diff updated, but please note that this patch would break compatibility with NetworlManager, and with existing configured networks. I still think changes are reasonable, but had to be synchronized with similar changes in NetworkManager. Not that those are difficult, I may be able to implement them, but need to be done. Until all parties agree, I'd recommend not implementing this

Mar 5 2019, 6:11 PM · Plasma
enriquem updated the diff for D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time.
Mar 5 2019, 6:07 PM · Plasma
enriquem added a comment to D17487: Check if the form has changed, and only reconnect if it has.

That is correct. It was fixed with a different approach

Mar 5 2019, 5:40 PM · Plasma

Feb 2 2019

enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

Changed tooltips

Feb 2 2019, 8:56 PM · Plasma
enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

Changed tooltips
No need for a new enum

Feb 2 2019, 7:36 AM · Plasma

Feb 1 2019

enriquem updated the diff for D18394: Add OTP support for openconnect VPN.
  • Removed updateLog calls
  • Properly initialize d->tokens
  • Change the config dialog so that (a) 'Apply' does not become active when the user clicks on the 'Show Tokens' button, makes no changes, and closes the dialog or clicks Cancel, and (b) when the user clicks 'Cancel', inputs read from the config file are restored
  • Added minimal tooltips (should be improved)
Feb 1 2019, 6:39 PM · Plasma

Jan 25 2019

enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

Corrects minor bug in one call to updateLog. However, all calls to updateLog have to be reviewed if this goes to production

Jan 25 2019, 7:33 PM · Plasma

Jan 21 2019

enriquem updated the summary of D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time.
Jan 21 2019, 9:05 PM · Plasma
enriquem requested review of D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time.
Jan 21 2019, 8:16 PM · Plasma

Jan 20 2019

enriquem updated the diff for D18394: Add OTP support for openconnect VPN.
Jan 20 2019, 5:44 PM · Plasma
enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

Changed the buildup of the "tokens" ComoBox

Jan 20 2019, 4:05 PM · Plasma
enriquem updated the diff for D18394: Add OTP support for openconnect VPN.
Jan 20 2019, 10:04 AM · Plasma
enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

Amended to remove global tokenModeList

Jan 20 2019, 10:03 AM · Plasma

Jan 19 2019

enriquem updated the diff for D18394: Add OTP support for openconnect VPN.

I addressed your comments, except the ones regarding macro definitions, since I am unsure thar applicable versions of openconnect have compatible parameters. I will find out and revisit the comment later

Jan 19 2019, 11:48 PM · Plasma
enriquem updated the diff for D18394: Add OTP support for openconnect VPN.
Jan 19 2019, 9:44 PM · Plasma
enriquem requested review of D18394: Add OTP support for openconnect VPN.
Jan 19 2019, 7:49 PM · Plasma

Jan 7 2019

enriquem updated the diff for D17834: Allow the use of One-Time Password.

Now it builds.

Jan 7 2019, 10:47 AM · Plasma

Jan 5 2019

enriquem updated the diff for D17834: Allow the use of One-Time Password.

I implemented all of your comments, reverting to my previous approach

Jan 5 2019, 7:04 PM · Plasma
enriquem added inline comments to D17834: Allow the use of One-Time Password.
Jan 5 2019, 7:03 PM · Plasma
enriquem updated the diff for D17834: Allow the use of One-Time Password.

Treat otp-flags the same way NetworkManager-fortisslvpn does

Jan 5 2019, 5:09 PM · Plasma
enriquem added a comment to D17834: Allow the use of One-Time Password.

I see. Maybe do not set it at all if one-time password is not used and let NM to set the default value? That way we won't be using a wrong value in case this changes in future.

Fair enough. I will update the diff with this. However, judging from the current behavior, if we do not set the value, nothing will be added to the config file. No harm will be made, though.

Jan 5 2019, 5:07 PM · Plasma
enriquem updated the diff for D17834: Allow the use of One-Time Password.

Removed setting the otp-flag in case it is not needed for the connection

Jan 5 2019, 4:18 PM · Plasma
enriquem added a comment to D17834: Allow the use of One-Time Password.

I see. Maybe do not set it at all if one-time password is not used and let NM to set the default value? That way we won't be using a wrong value in case this changes in future.

Jan 5 2019, 4:16 PM · Plasma

Jan 4 2019

enriquem updated the diff for D17834: Allow the use of One-Time Password.

I implemented all of your comments except one. I created a new VPN setting wit nm-connection-editor, and it sets it to 0, that is, to NetworkManager::Setting::None. Thus, I believe that part is correct.

Jan 4 2019, 9:23 PM · Plasma

Jan 3 2019

enriquem updated the diff for D17834: Allow the use of One-Time Password.

Treated otp-flags the same way as password-flags. But we have to be careful to consider the case where the option is not yet in the config file (as will certainly be the case the firs time it is used if there was a vpn already configured), so I added a isEmpty() test not to break the toInt() call.

Jan 3 2019, 5:56 PM · Plasma

Dec 30 2018

enriquem updated the diff for D17834: Allow the use of One-Time Password.
Dec 30 2018, 1:53 PM · Plasma

Dec 28 2018

enriquem added a comment to D17834: Allow the use of One-Time Password.

You are, of course, correct. How can I have missed that?

Dec 28 2018, 11:19 PM · Plasma
enriquem updated the diff for D17834: Allow the use of One-Time Password.
Dec 28 2018, 11:19 PM · Plasma
enriquem requested review of D17834: Allow the use of One-Time Password.
Dec 28 2018, 4:54 PM · Plasma

Dec 10 2018

enriquem requested review of D17487: Check if the form has changed, and only reconnect if it has.
Dec 10 2018, 4:35 PM · Plasma