Differential D29785

Always use Window colorset for AbstractApplicationHeader
ClosedPublic
Actions

Authored by ngraham on May 15 2020, 5:40 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:5a716f3947dd: Always use Window colorset for AbstractApplicationHeader
Summary

...Otherwise when an AbstractApplicationHeader is used on a page that
overrides the color set, such as ScrollablePage, the header color is
inappropriately set to the view BG color.

BUG: 421573
CCBUG: 421571
FIXED-IN: 5.71

Test Plan

List view of Cards and Grid view of Cards in Kirigami gallery look
correct now:

Diff Detail

Repository
R169 Kirigami
Branch
always-use-window-colorset-for-application-header (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26970
Build 26988: arc lint + arc unit
ngraham created this revision.May 15 2020, 5:40 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMay 15 2020, 5:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 15 2020, 5:40 PM
ngraham edited the summary of this revision. (Show Details)May 15 2020, 5:47 PM
apol added a subscriber: apol.May 18 2020, 1:00 PM

I wonder if this should be specified in ToolBarApplicationHeader instead.

ngraham added a comment.May 18 2020, 1:16 PM

Not all of the headers use toolbars, but I thought the idea was for them all to use a consistent base appearance? @mart?

mart accepted this revision.May 18 2020, 1:17 PM
This revision is now accepted and ready to land.May 18 2020, 1:17 PM
Closed by commit R169:5a716f3947dd: Always use Window colorset for AbstractApplicationHeader (authored by ngraham). · Explain WhyMay 18 2020, 1:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82968

View Options

src/styles/org.kde.desktop/AbstractApplicationHeader.qml

Loading...