- Use ECM for adding tests
- Use consistent naming for CMake functions
- Only add tests when adding -DBUILD_TESTING
- Code formatting
- Use option for options
- Use ECM for version number and change version number from 2.49.beta to 2.49.90
Details
Details
- Reviewers
niccolove iasensio alex - Commits
- R1050:7b7c9ddd6165: Refactor CMakeFiles
make -j8 install works and make test too
Diff Detail
Diff Detail
- Repository
- R1050 BasKet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/CMakeLists.txt | ||
---|---|---|
138 | I plan to either remove the broken KPART integration or to fix it in a followup patch. KDEUI/kdeui was from KDE4 according to Google. |
src/CMakeLists.txt | ||
---|---|---|
168 | Would you mind to expand the FILES list, one per line? I don't know if this is usual in kde codebase but having tried myself, it seems much more clear to me when there are a lot of files. |