Refactor CMakeFiles
ClosedPublic
Actions

Authored by ognarb on May 13 2020, 3:42 PM.

Details

Reviewers

Commits

R1050:7b7c9ddd6165: Refactor CMakeFiles

Summary

Test Plan

make -j8 install works and make test too

Repository

R1050 BasKet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ognarb requested review of this revision.May 13 2020, 3:42 PM

ognarb created this revision.

src/CMakeLists.txt
138	I plan to either remove the broken KPART integration or to fix it in a followup patch. KDEUI/kdeui was from KDE4 according to Google.

ognarb edited the test plan for this revision. (Show Details)May 13 2020, 3:53 PM

src/CMakeLists.txt
168	Would you mind to expand the FILES list, one per line? I don't know if this is usual in kde codebase but having tried myself, it seems much more clear to me when there are a lot of files. Feel free to ignore this, of course.

This revision is now accepted and ready to land.May 13 2020, 7:07 PM

This revision was automatically updated to reflect the committed changes.

ognarb marked an inline comment as done.

			Path	Packages
M			CMakeLists.txt (168 lines)
M			src/CMakeLists.txt (128 lines)
M			src/notecontent.h (29 lines)
M			src/tests/CMakeLists.txt (52 lines)
M			src/tests/basketviewtest.cpp (5 lines)
M			src/tests/notetest.cpp (4 lines)
M			src/tests/toolstest.cpp (2 lines)
M			src/tools.h (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82758	80c68df		May 13 2020, 3:42 PM	★	★
Diff 2	82763	80c68df	* Extend files	May 13 2020, 4:04 PM	★	★
Diff 3	82785	c09141b	R1050:7b7c9ddd6165875381df08bb557568abbca0540b	May 13 2020, 7:10 PM	★	★