Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT
ClosedPublic
Actions

Authored by kossebau on May 13 2020, 1:08 PM.

Details

Reviewers

dfaure
meven
ahmadsamir

Group Reviewers

Frameworks

Commits

R241:391351a6be0e: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

Summary

Not all versions of the past will work as value, mainly to be used with
values "0" or "CURRENT". If any new deprecations are done without
having code starting to use older deprecated API, in the future any
versions >= 5.71.0 should work also reliably.

Currently a build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT does
not yet work, some API deprecated is still used internally by
code behind non-deprecated API. Building with CURRENT will show by the
failed build which those are.

Test Plan

Builds with values 0, 5.70.0 (with D29707).

Diff Detail

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.May 13 2020, 1:08 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMay 13 2020, 1:08 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.May 13 2020, 1:08 PM

Harbormaster completed remote builds in B26832: Diff 82730.May 13 2020, 1:08 PM

@dfaure So far I had no idea how to introduce a simple variant of the deprecation macros to support just disabling latest. For one would this make things more complex as there would be yet another approach. And things would be also become a bit unreliable on the library consumer side, as any version-less BUILD_DEPRECATED would no longer be bound to a version and thus to a certain set of API.

And as said in the commit message, the current version-based EXCLUDE_DEPRECATED_BEFORE_AND_AT can also be used with KIO, if we simply just give no guarantee that this works with any version, but only with some, with better chances for future versions (if people now make sure things build without deprecated API and do not reintroduce the use of already deprecated API) :)

Using this patch with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT shows that there are lots of KRun::run* usages in non-deprecated API sadly in KIO :(

Great stuff, this much less cleanup will be needed for KF6 !

src/core/global.cpp
99	Pretty old deprecation ^^

This revision is now accepted and ready to land.May 13 2020, 1:33 PM

there are lots of KRun::run* usages in non-deprecated API sadly in KIO :(

OK, I'll fix that.

Closed by commit R241:391351a6be0e: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT (authored by kossebau). · Explain WhyMay 14 2020, 12:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			autotests/CMakeLists.txt (14 lines)
M			autotests/clipboardupdatertest.cpp (6 lines)
M			autotests/kfilewidgettest.cpp (2 lines)
M			autotests/krununittest.h (3 lines)
M			autotests/krununittest.cpp (5 lines)
M			autotests/kurlnavigatortest.h (3 lines)
M			autotests/kurlnavigatortest.cpp (4 lines)
M			src/core/CMakeLists.txt (1 line)
M			src/core/copyjob.cpp (10 lines)
M			src/core/global.cpp (4 lines)
M			src/core/idleslave.cpp (6 lines)
M			src/core/job.cpp (3 lines)
M			src/core/kfileitem.cpp (8 lines)
M			src/core/ksambashare.cpp (7 lines)
M			src/core/ksambashare_p.h (2 lines)
M			src/core/ksslcertificatemanager.h (6 lines)
M			src/core/ksslcertificatemanager.cpp (25 lines)
M			src/core/ksslcertificatemanager_p.h (2 lines)
M			src/core/ksslerror_p.h (2 lines)
M			src/core/ksslerroruidata.cpp (2 lines)
M			src/core/ktcpsocket.cpp (6 lines)
M			src/core/scheduler.cpp (6 lines)
M			src/core/slavebase.cpp (8 lines)
M			src/core/slaveinterface.cpp (8 lines)
M			src/core/statjob.cpp (6 lines)
M			src/core/transferjob.cpp (4 lines)
M			src/core/udsentry.cpp (10 lines)
M			src/filewidgets/CMakeLists.txt (1 line)
M			src/filewidgets/kfilepreviewgenerator.cpp (3 lines)
M			src/filewidgets/kfilewidget.cpp (2 lines)
M			src/filewidgets/kurlnavigator.cpp (18 lines)
M			src/kssld/kssld.cpp (7 lines)
M			src/widgets/CMakeLists.txt (1 line)
M			src/widgets/accessmanager.cpp (4 lines)
M			src/widgets/kdirmodel.cpp (2 lines)
M			src/widgets/kpropertiesdialog.cpp (2 lines)
M			src/widgets/krun.cpp (36 lines)
M			src/widgets/ksslinfodialog.h (1 line)
M			src/widgets/ksslinfodialog.cpp (4 lines)
M			src/widgets/kurifilter.cpp (2 lines)
M			src/widgets/kurlrequester.h (2 lines)
M			src/widgets/kurlrequester.cpp (6 lines)
M			src/widgets/kurlrequesterdialog.cpp (2 lines)
M			src/widgets/paste.cpp (8 lines)
M			src/widgets/previewjob.cpp (8 lines)
M			src/widgets/renamedialog.cpp (2 lines)
M			src/widgets/sslui.cpp (2 lines)
M			src/widgets/thumbcreator.cpp (2 lines)
M			tests/CMakeLists.txt (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82730	e1cf2c8		May 13 2020, 1:08 PM	★	★
Diff 2	82806	c7b1644	R241:391351a6be0e8c70db2579432abc673e280fb142	May 13 2020, 11:59 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
15e3afd81e10	772c1b989068	e1cf2c893eb7	Friedrich W. H. Kossebau	Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT (Show More…)	May 13 2020, 12:35 PM

Introduce EXCLUDE_DEPRECATED_BEFORE_AND_ATClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 82806

CMakeLists.txt

autotests/CMakeLists.txt

autotests/clipboardupdatertest.cpp

autotests/kfilewidgettest.cpp

autotests/krununittest.h

autotests/krununittest.cpp

autotests/kurlnavigatortest.h

autotests/kurlnavigatortest.cpp

src/core/CMakeLists.txt

src/core/copyjob.cpp

src/core/global.cpp

src/core/idleslave.cpp

src/core/job.cpp

src/core/kfileitem.cpp

src/core/ksambashare.cpp

src/core/ksambashare_p.h

src/core/ksslcertificatemanager.h

src/core/ksslcertificatemanager.cpp

src/core/ksslcertificatemanager_p.h

src/core/ksslerror_p.h

src/core/ksslerroruidata.cpp

src/core/ktcpsocket.cpp

src/core/scheduler.cpp

src/core/slavebase.cpp

src/core/slaveinterface.cpp

src/core/statjob.cpp

src/core/transferjob.cpp

src/core/udsentry.cpp

src/filewidgets/CMakeLists.txt

src/filewidgets/kfilepreviewgenerator.cpp

src/filewidgets/kfilewidget.cpp

src/filewidgets/kurlnavigator.cpp

src/kssld/kssld.cpp

src/widgets/CMakeLists.txt

src/widgets/accessmanager.cpp

src/widgets/kdirmodel.cpp

src/widgets/kpropertiesdialog.cpp

src/widgets/krun.cpp

src/widgets/ksslinfodialog.h

src/widgets/ksslinfodialog.cpp

src/widgets/kurifilter.cpp

src/widgets/kurlrequester.h

src/widgets/kurlrequester.cpp

src/widgets/kurlrequesterdialog.cpp

src/widgets/paste.cpp

src/widgets/previewjob.cpp

src/widgets/renamedialog.cpp

src/widgets/sslui.cpp

src/widgets/thumbcreator.cpp

tests/CMakeLists.txt

Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT
ClosedPublic
Actions

Revision Contents
Changeset List