Exclude all loop devices from partition and disk sensors
ClosedPublic

Authored by ahiemstra on May 12 2020, 5:53 PM.

Details

Summary

Since there is little reason to monitor loop devices, exclude them
altogether from the partition and disk sensors.

This fixes cases where there are a significant amount of snaps,
which are all mounted as loop devices and thus cause partition and
disk sensors to appear, which potentially causes major slowdowns.

Test Plan

Snaps are excluded from the list of sensors in KSysGuard.

Diff Detail

Repository
R106 KSysguard
Branch
ignore_snap_partitions
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26838
Build 26856: arc lint + arc unit
ahiemstra created this revision.May 12 2020, 5:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 12 2020, 5:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.May 12 2020, 5:53 PM
davidedmundson accepted this revision.May 12 2020, 8:57 PM
This revision is now accepted and ready to land.May 12 2020, 8:57 PM

This didn't seem to work for me when I compiled and installed it and rebooted to check, still takes lots of disk to make the computer unuseable

Should it /var/lib/flatpak (or just /flatpak/) be included as well?

Maybe also /var/lib/docker?

Should it /var/lib/flatpak (or just /flatpak/) be included as well?

Flatpak doesn't use mounts for this as far as I can tell, or at least they don't show up in mtab. So flatpak does not cause problems.

Maybe also /var/lib/docker?

Docker mounts already seem to be ignored, at least on my system.

ahiemstra updated this revision to Diff 82738.May 13 2020, 1:55 PM
  • Exclude all loop devices from partition and disk sensors
ahiemstra retitled this revision from Ignore mount paths that start with '/snap/' to Exclude all loop devices from partition and disk sensors.May 13 2020, 2:01 PM
ahiemstra edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.