| ngraham | |
| broulik |
| Plasma |
It would be correct to close the Clipboard applet after clearing the history or deleting the last element, since there is nothing more to do with the empty Clipboard applet (similar to how the Notification applet closes after the last notification is removed).
BUG: 421345
FIXED-IN: 5.20
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
(similar to how the Notification applet closes after the last notification is removed).
But you're changing that in D29651?
Currently, the Notifications applet closes itself when the last element (notification) is removed (or if all elements are removed by pressing "Clear History" button in the top-right corner). But also it closes itself, even if the applet is pinned, and I guess that this behaviour isn't correct. D29651 fixes this issue.
Currently, the Clipboard applet remains visible when the last element (fragment) is removed (or if all elements are removed by clicking "Clear History" button in the top-right corner), even if the applet isn't pinned. This patch makes the Clipboard applet to close itself if there are no elements in the clipboard history and it's not pinned.
| applets/clipboard/contents/ui/clipboard.qml | ||
|---|---|---|
| 33 ↗ | (On Diff #82859) | For correctness, you should still set this value even if the binding is later broken in onIsClipboardEmptyChange , so the initial state isn't ambiguous. |