Differential D2960

[shell] Fix non-interactive panelview on non-primary screen
ClosedPublic
Actions

Authored by bshah on Oct 6 2016, 11:04 AM.

Details

Reviewers
sebas
mart
graesslin
Group Reviewers
Plasma
Commits
R871:9c94cd136006: [shell] Fix non-interactive panelview on non-primary screen
R120:9c94cd136006: [shell] Fix non-interactive panelview on non-primary screen
Summary

If we don't pass the current screen to QCursor::pos, it will return
position relative to primary screen, which obviously won't be in panel
geometry.

Instead pass it currentScreen, this way we don't filter out the mouse
events for panel.

BUG: 368790
FIXED-IN: 5.8.1

Test Plan

added debug statements and verified that I get correct screen position
and as well, panel is now interactive on secondary screen.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah updated this revision to Diff 7143.Oct 6 2016, 11:04 AM
bshah retitled this revision from to [shell] Fix non-interactive panelview on non-primary screen.
bshah updated this object.
bshah edited the test plan for this revision. (Show Details)
bshah added reviewers: Plasma, mart, graesslin.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 6 2016, 11:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.Oct 6 2016, 11:18 AM
graesslin edited edge metadata.

yay, I finally was able to remove the stupid panel on my second screen!

This revision is now accepted and ready to land.Oct 6 2016, 11:18 AM
sebas accepted this revision.Oct 6 2016, 2:07 PM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.

Tested on X11, no regressions observed, panels on a second screen still work.

Closed by commit R120:9c94cd136006: [shell] Fix non-interactive panelview on non-primary screen (authored by bshah). · Explain WhyOct 6 2016, 3:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/panelview.cpp (4 lines)

Diff 7161

View Options

shell/panelview.cpp

Loading...