Just some little things :-)
- Refactor foreach
- Fix minor formatting issues
- Use auto keyword where appropiate
ngraham | |
elvisangelaccio |
Dolphin |
Just some little things :-)
Compiles
No Linters Available |
No Unit Test Coverage |
Buildable 26612 | |
Build 26630: arc lint + arc unit |
+1 overall, though I'm not sure changing those things to auto is needed or beneficial.
src/settings/services/servicessettingspage.cpp | ||
---|---|---|
63 | Not sure changing these to auto is needed |
src/settings/services/servicessettingspage.cpp | ||
---|---|---|
123–124 | Please no, this looks really bad. I'd just revert all these line splittings honestly. What's the gain? |
src/settings/services/servicessettingspage.cpp | ||
---|---|---|
123–124 | Sorry, I accidentally ran the automatic formatter when I made that last minor change, my bad :-( |