[Next up, KRun::displayOpenWithDialog]
Details
Diff Detail
- Repository
- R241 KIO
- Branch
- 2020_05_deprecate_KRun_run_methods
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26659 Build 26677: arc lint + arc unit
src/widgets/krun.h | ||
---|---|---|
216 ↗ | (On Diff #82325) | I don't think you want both @deprecated? |
229 ↗ | (On Diff #82325) | You meant "5, 71" |
369 ↗ | (On Diff #82325) | But OpenUrlJob is in 5.71 not 5.31? people will be reading that on api.kde.org not only in 5.71 header files, right? |
380 ↗ | (On Diff #82325) | The same issue 5.31 vs 5.71. |
452 ↗ | (On Diff #82325) | Missing @deprecated. |
599 ↗ | (On Diff #82325) | So, you're keeping the name slotTimout? I guess after 5-10 years, no point changing it :) |
src/widgets/krun.h | ||
---|---|---|
216 ↗ | (On Diff #82325) | I did, but Friedrich had a less confusing suggestion: @deprecated since 5.6. Since 5.71 use ApplicationLauncherJob, otherwise runApplication instead. |
229 ↗ | (On Diff #82325) | No, we want this method to be deprecated since 5.6. |
369 ↗ | (On Diff #82325) | Right, same A->B->C problem here. I'll use the same solution. |
380 ↗ | (On Diff #82325) | Same thing. Whatever the text is, the important bit is that this warns when asking for deprecation warnings ">= 5.31" |
452 ↗ | (On Diff #82325) | Well spotted. |
599 ↗ | (On Diff #82325) | I'm going to deprecate the whole KRun class, so this TODO is irrelevant. |
src/widgets/krun.h | ||
---|---|---|
216 ↗ | (On Diff #82325) | Yeah, makes sense; the point is keeping the users of the class informed/aware anyway. |